DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code

MIT License

24 stars 8 forks source link

Closed andrewpeng02 closed 9 months ago

andrewpeng02 commented 9 months ago

Dockerize the /training route backend

What user problem are we solving? In order to eventually deploy and easily scale the /training endpoints, we want to put it in docker containers.

What solution does this PR provide? I created both a dev and prod docker containers that can be created with docker-compose

Testing https://youtu.be/TdtIas9IEbU

sweep-ai[bot] commented 9 months ago

karkir0003 commented 9 months ago

@andrewpeng02 can you add a test plan or screen recording to test that the dockerfile works?

karkir0003 commented 9 months ago

looks good to me. put two minor questions

karkir0003 commented 9 months ago

@dwu359 can we link a github issue (if any) to this PR?

karkir0003 commented 9 months ago

@andrewpeng02 can we update readme on how to run the dockerfiles?

karkir0003 commented 9 months ago

@dwu359 what cmd did u run?

@andrewpeng02

dwu359 commented 9 months ago

@dwu359 what cmd did u run?

@andrewpeng02

docker-compose up --build

karkir0003 commented 9 months ago

@dwu359 what cmd did u run? @andrewpeng02

docker-compose up --build

run within training/ directory?

karkir0003 commented 9 months ago

@andrewpeng02 docker image works on my end with dev mode

karkir0003 commented 9 months ago

@andrewpeng02 some build checks failed

sonarcloud passed

karkir0003 commented 9 months ago

@andrewpeng02 u should be unblocked!!

karkir0003 commented 9 months ago

@dwu359 i approved on my end. can @andrewpeng02 merge?

andrewpeng02 commented 9 months ago

I need to push a quick fix first

sonarcloud[bot] commented 9 months ago

The SonarCloud Quality Gate passed, but some issues were introduced.