DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code
MIT License
24 stars 8 forks source link

Change region to 'us-east-1' and set custom exception for incomplete AWS credential steps #1085

Closed LuHG18 closed 9 months ago

LuHG18 commented 9 months ago

Change region to 'us-east-1' and set custom exception for incomplete AWS credential steps

Github Issue Number Here: #1084 Issue Description Bug preventing access to user id tokens through the dlp-cli with unclear error message

Solution Edited cli.py file to use the correct region (us-east-1) and added custom exception providing a more detailed error description in the case where dlp-cli user did not complete the necessary AWS credential steps.

Testing Methodology Tested the updates by using the dlp-cli to obtain a valid id token. First by not completing the proper AWS credential steps to prompt the custom exception and second by filling out the necessary steps and successfully getting the token.

https://drive.google.com/file/d/1jThsq6Xznm4oAS_NN-o_Yt-7nBc_K5v_/view?usp=sharin

sweep-ai[bot] commented 9 months ago

Apply Sweep Rules to your PR?

karkir0003 commented 9 months ago

@LuHG18 can you share a video recording/screen recording of you walking through the testing steps :)

karkir0003 commented 9 months ago

Thank you for this PR @LuHG18 🥳

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud