search

DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code
MIT License
26 stars 8 forks source link

[FEATURE]: Proposed Frontend Build Check Workflow #1086

Open prishavall opened 10 months ago

prishavall commented 10 months ago

Feature Name

unified Frontend build check workflow to ensure code quality and consistency

Your Name

Prisha Vallamsetti

Description

  1. Linting: Checkout codebase "npm install -g pnpm" Install dependencies using pnpm install Run Prettier to ensure code formatting consistency (yarn run format:check) Run ESLint (yarn run lint) ensuring its execution separate of Prettier's success
  2. Building & Staging: Checkout codebase Install dependencies using pnpm install Build the frontend assets using yarn build Stage the built assets using a custom action rossjrw/pr-preview-action@v1 to create a preview environment
  3. Testing: Checkout codebase Install dependencies using pnpm install Run tests with coverage using yarn run test --coverage The workflow configuration is triggered on each pull request so each step is reached and checked
github-actions[bot] commented 10 months ago

Hello @prishavall! Thank you for submitting the Feature Request Form. We appreciate your contribution. :wave:

We will look into it and provide a response as soon as possible.

To work on this feature request, you can follow these branch setup instructions:

  1. Checkout the main branch:

     git checkout nextjs

  2. Pull the latest changes from the remote main branch:

     git pull origin nextjs

  3. Create a new branch specific to this feature request using the issue number:

     git checkout -b feature-1086

    Feel free to make the necessary changes in this branch and submit a pull request when you're ready.

    Best regards, Deep Learning Playground (DLP) Team

karkir0003 commented 10 months ago

use pnpm as the dependency manager, not yarn