search

DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code
MIT License
26 stars 8 forks source link

[BUG]: Remove yarn.lock file #1117

Closed karkir0003 closed 9 months ago

karkir0003 commented 9 months ago

Operating system

N/A

Bug description

Context DLP transitioned from yarn to pnpm as the package manager for frontend dependencies. However, in the frontend/ directory of the project, the yarn.lock file still persists. We don't require this file as a pnpm-lock.yaml file is generated from pnpm.

Solution:

  1. Remove the yarn.lock file from frontend/ directory/folder.
  2. Create a pull request and tag @Project Lead in discord (with link to the pull request)

Steps to reproduce

Examine the frontend/ directory and check that the yarn.lock file is there

github-actions[bot] commented 9 months ago

Hello @karkir0003! Thank you for submitting the 🐞Bug Request Form. We appreciate your contribution. :wave:

We will look into it and provide a response as soon as possible.

To work on this bug request, you can follow these branch setup instructions:

  1. Checkout the main branch:

     git checkout nextjs

  2. Pull the latest changes from the remote main branch:

     git pull origin nextjs

  3. Create a new branch specific to this bug request using the issue number:

     git checkout -b bug-1117

    Feel free to make the necessary changes in this branch and submit a pull request when you're ready.

    Best regards, Deep Learning Playground (DLP) Team

karkir0003 commented 9 months ago

Steps on how to test your changes:

  1. After removing the yarn.lock file from frontend/, please run dlp-cli frontend start and verify that localhost:3000 renders the app. You will also need to run dlp-cli backend start in a separate terminal window to load up the backend
farisdurrani commented 9 months ago

Completed in a previous PR