Update get_trainspace and get_all_trainspaces to reflect new dynamo tables - Githubissues

DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code

MIT License

24 stars 8 forks source link

Update get_trainspace and get_all_trainspaces to reflect new dynamo tables #1121

Closed ssh51117 closed 7 months ago

ssh51117 commented 7 months ago

Update get_trainspace and get_all_trainspaces to reflect new dynamo tables

Github Issue Number Here: #1120 What user problem are we solving? Old GET endpoints pointed to the wrong table in dyanmodb What solution does this PR provide? Updated the endpoints to get trainspaces from the new dynamodb table

Testing Methodology

How did you test your changes and verify that existing functionality is not broken Tested getting each trainspace in the table by trainspace_id. Tested get all by running it normally and by forcing user_id to be a different uid from the table. screen recording of testing: https://youtu.be/hVtTP7Maalo

sonarcloud[bot] commented 7 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

karkir0003 commented 7 months ago

@ssh51117 is this new trainspace table in us-east-1?

ssh51117 commented 7 months ago

@ssh51117 is this new trainspace table in us-east-1?

yes, it's TrainspaceTable in us-east-1.

farisdurrani commented 7 months ago

lgtm, feel free to merge