DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code
MIT License
24 stars 8 forks source link

Feature 1123 Added Trainspace, Model, User Tables to Terraform Infra #1126

Closed MugPand closed 7 months ago

MugPand commented 7 months ago

DynamoDB & Terraform Update

Github Issue Number Here: GitHub #1123 What user problem are we solving? The current DynamoDB tables and Terraform script reflect an older version of infra-configurations.

What solution does this PR provide? Updated DynamoDB tables and Terraform script to reflect new changes proposed by the following diagram: Also added user_id as GSI to ModelTable. image

Testing Methodology

How did you test your changes and verify that existing functionality is not broken Ran terraform file configurations and validated created DynamoDB Tables on AWS.

Any other considerations

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

farisdurrani commented 7 months ago

This isn't mandatory but do try applying the tf plan and then destroy the built resources to make sure the .tf file works.

terraform init
terraform fmt
terraform plan
terraform apply
terraform destroy

It may not work if you don't have the proper access. I'll approve this after 24 hours to see if anyone else has any comments

MugPand commented 7 months ago

This isn't mandatory but do try applying the tf plan and then destroy the built resources to make sure the .tf file works.

terraform init
terraform fmt
terraform plan
terraform apply
terraform destroy

It may not work if you don't have the proper access. I'll approve this after 24 hours to see if anyone else has any comments

@karkir0003 and I just tested that successfully.

karkir0003 commented 7 months ago

This isn't mandatory but do try applying the tf plan and then destroy the built resources to make sure the .tf file works.

terraform init
terraform fmt
terraform plan
terraform apply
terraform destroy

It may not work if you don't have the proper access. I'll approve this after 24 hours to see if anyone else has any comments

can we make this a best practice for tf related stuff?? can it be automated

farisdurrani commented 7 months ago

Yes, this should be best practice. Can it be automated? Yes, but I won't recommend it. If it fails, there may be AWS resources that will never get destroyed (more cost)

farisdurrani commented 7 months ago

Feel free to merge @MugPand