DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code

MIT License

26 stars 8 forks source link

Add load balancer to allowed hosts for aws deployment #1130

Closed andrewpeng02 closed 9 months ago

andrewpeng02 commented 9 months ago

Add load balancer to allowed hosts for aws deployment

What user problem are we solving? Because the ALLOWED_HOSTS is empty, the backend was refusing to return requests to the aws load balancer

What solution does this PR provide? Adds the relevant ips to allowed hosts

Testing Methodology Change redirect for /api/training to use http://backend-load-balancer-296304048.us-east-1.elb.amazonaws.com instead of localhost in next.config.js and try to train a new model

https://github.com/DSGT-DLP/Deep-Learning-Playground/assets/47485510/4194f682-d7f6-4088-9c15-1fdfbb08193b

sonarcloud[bot] commented 9 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

farisdurrani commented 9 months ago

lgtm, ignore the githubactions errors if you're confident it's working as intended. Unfortunately GA does not have access to a working Python env to make accurate statements. Wait until tomorrow or until another PL approves before you merge

karkir0003 commented 9 months ago

lgtm, ignore the githubactions errors if you're confident it's working as intended. Unfortunately GA does not have access to a working Python env to make accurate statements. Wait until tomorrow or until another PL approves before you merge

I wonder if we can ensure that in our github actions checks? I can try digging into this for a bit, but not the highest priority problem to solve