DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code
MIT License
24 stars 8 forks source link

Feature 1124 user table #1145

Closed ssh51117 closed 6 months ago

ssh51117 commented 7 months ago

Removing Redundent code in user unit tests

1124

What user problem are we solving? There were a couple unused imports and code snippets What solution does this PR provide? I removed these imports and code snippets Testing Methodology

How did you test your changes and verify that existing functionality is not broken I reran the unit tests after removing the extra code and ensured that they still passed and worked.

image

Any other considerations Added complete vitest and dynamodb mocking guides on notion vitest link: https://www.notion.so/Using-Vitest-for-Unit-Testing-1ccb7a93b51d4887a69ab6d10f408021?pvs=4 dynamodb mocking link: https://www.notion.so/DynamoDB-mocking-9fefc3cf8be94048b7e054d6863987c5?pvs=4

karkir0003 commented 7 months ago

link to guide on notion @ssh51117

ssh51117 commented 7 months ago

link to guide on notion @ssh51117

added @karkir0003

karkir0003 commented 6 months ago

link to guide on notion @ssh51117

added @karkir0003

@ssh51117 guide looks really well written :)

karkir0003 commented 6 months ago

@ssh51117 can u please fix the merge conflicts!

karkir0003 commented 6 months ago

link to guide on notion @ssh51117

added @karkir0003

@ssh51117 can we update the Notion with the new unit test samples + info on the vitest config stuff

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codingwithsurya commented 6 months ago

great job! feel free to merge in @ssh51117