Closed andrewpeng02 closed 6 months ago
Issues
3 New issues
54 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
@andrewpeng02 Question RE testing video:
AWESOME PR @andrewpeng02 . I left a few nits in the PR, but looks really good.
Quick question: Will there be any documentation to understand the development process for say adding a new training type now that we have a celery based structure?
It shouldn't be difficult to support new training types, you should be able to figure it out by referencing the existing tabular and image training jobs
Issues
2 New issues
42 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code
Migrate training into celery and upload results to s3
Github Issue Number Here: #1136 What user problem are we solving?
What solution does this PR provide? Training jobs are executed by a celery worker, which polls from the queue set up in aws sqs. Currently you have to run the celery worker locally, but eventually the workers will run in the g4dn.xlarge ec2 instances. In this pr, I added celery endpoints which the backend will call. Then, the frontend will request the training results data from
GET /api/training/results/{trainspaceId}
, and it'll display the data.I also moved some files into /celery to make it more clear that the celery worker will operate in there (but it'll also access files in the django app)
Testing Methodology
dlp-cli frontend start
AWS_PROFILE=dlp docker compose up --build
AWS_PROFILE=sst
https://github.com/DSGT-DLP/Deep-Learning-Playground/assets/47485510/0fb5a43e-0948-4029-b8d7-575a288997ad
Any other considerations