search

DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code
MIT License
26 stars 8 forks source link

modify dev instructions to require docker #1183

Closed andrewpeng02 closed 6 months ago

andrewpeng02 commented 6 months ago

Because of the changes to dlp-cli backend start, it's no longer necessary to install the backend manually. See https://github.com/DSGT-DLP/dlp-cli/pull/16

https://github.com/DSGT-DLP/Deep-Learning-Playground/assets/47485510/9af41ad2-d8c0-4d60-83e9-f4a50f92c294

sweep-ai[bot] commented 6 months ago

Sweep: PR Review

README.md

The changes update the README.md to include Docker Desktop as a prerequisite, remove Docker from the recommended tools, and streamline backend package installation by automating it during the backend start process.

Sweep Found These Issues

  • Removing the manual backend installation step may cause issues if dlp-cli backend start fails to handle dependency installation correctly.
    • https://github.com/DSGT-DLP/Deep-Learning-Playground/blob/190cf22ecddfff7d7986f60a9d005ecc0517da67/README.md#L74-L76 [View Diff](https://github.com/DSGT-DLP/Deep-Learning-Playground/pull/1183/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R74-R76)
training/docker-compose.yml

The change allows the host port for the "web" service to be dynamically set using the BACKEND_PORT environment variable, defaulting to 8000 if not defined.

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud