DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code
MIT License
26 stars 8 forks source link

added spinner after training button #866

Closed prishavall closed 1 year ago

prishavall commented 1 year ago

Added Spinner after Training Button

What user problem are we solving? Needed a spinner icon that shows that the page is loading. The spinner also needs to be unclickable. After clicking the button to where the spinner shows up the train button needs to be disabled. What solution does this PR provide? Code added for inserting the spinner icon and disabling the train button with tabular/image Testing Methodology How did you test your changes and verify that existing functionality is not broken Tested on localhost:3000 both image/tabular New Recording - 7/14/2023, 1:36:14 PM Any other considerations

karkir0003 commented 1 year ago

Also, please fill in the "Title of PR field" at the top of the PR description @prishavall

farisdurrani commented 1 year ago

This is very good @prishavall . For aesthetic reasons, can you try putting the spinner inside the TRAIN button instead so it doesn't create an awkward layout

karkir0003 commented 1 year ago

This is very good @prishavall . For aesthetic reasons, can you try putting the spinner inside the TRAIN button instead so it doesn't create an awkward layout

could you put this as a suggestion in github PR (so that you can show what the code would look like with your suggestion) @farisdurrani

farisdurrani commented 1 year ago

This is very good @prishavall . For aesthetic reasons, can you try putting the spinner inside the TRAIN button instead so it doesn't create an awkward layout

could you put this as a suggestion in github PR (so that you can show what the code would look like with your suggestion) @farisdurrani

I would rather not. The change would be too big for a code suggestion, and the code implementation here is less important than the aesthetic goal