search

DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code
MIT License
26 stars 8 forks source link

[BUG]: poetry-lock precommit hook not working #880

Closed karkir0003 closed 10 months ago

karkir0003 commented 1 year ago

Operating system

Windows 11

Bug description

I tried committing some changes to removing unused frontend tsx code. I didn't change the pyproject.toml and when I commit the change and the poetry-lock pre-commit hook runs, i get a failed build check even though i didn't touch any poetry dependency.

Fix: update our poetry github action build check to make sure the poetry.lock file is up to date with pyproject.toml or identify a better workaround that isn't too slow

Steps to reproduce

  1. make some minor code change
  2. run git add . followed by git commit -m <message>
  3. see the pre-commit hooks running
github-actions[bot] commented 1 year ago

Hello @karkir0003! Thank you for submitting the Bug Request Form. We appreciate your contribution. :wave:

We will look into it and provide a response as soon as possible.

To work on this bug request, you can follow these branch setup instructions:

  1. Checkout the main branch:

     git checkout nextjs

  2. Pull the latest changes from the remote main branch:

     git pull origin nextjs

  3. Create a new branch specific to this bug request using the issue number:

     git checkout -b bug-880

    Feel free to make the necessary changes in this branch and submit a pull request when you're ready.

    Best regards, Deep Learning Playground (DLP) Team

codingwithsurya commented 1 year ago

@karkir0003 already tried this, but I was having same issue. I solved by updating dependencies and regenerating poetry lock file using:

poetry update

this is what worked for me in the last commit. Make sure you run poetry update in the correct subdirectories.

if that doesn't work, make sure to update and clean ur pre-commit cache.

pre-commit clean
pre-commit autoupdate

This is personally what worked for me, and I'm not sure why it's not working for @karkir0003. Some more info here:

https://github.com/python-poetry/poetry/issues/8189

karkir0003 commented 1 year ago

hmm. thats weird. im having austin tsst this out @codingwithsurya

karkir0003 commented 1 year ago

@Dashrekker @codingwithsurya is this solved?

codingwithsurya commented 1 year ago

@Dashrekker @codingwithsurya is this solved?

this works on my end.

i think this is more of a windows issue so you will have to test it on your end. @karkir0003