search

DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code
MIT License
24 stars 8 forks source link

Logo Functionality Changes #905

Closed prishavall closed 1 year ago

prishavall commented 1 year ago

Logo Functionality Changes

What user problem are we solving? Previously, hover functionality on the DLP logo on the very top left in the Nav Bar doesn't work since the nextjs Image component doesn't really work too well with Bootstrap components. What solution does this PR provide? The logo should changes color in the same way as the link next to it as you hover. Testing Methodology How did you test your changes and verify that existing functionality is not broken Ran local host and hovered/clicked to see functionality Any other considerations New Recording - 8/16/2023, 4:17:22 PM

karkir0003 commented 1 year ago

@farisdurrani

karkir0003 commented 1 year ago

@prishavall can u post a brief video/screen recording?

farisdurrani commented 1 year ago

Removed some commented code. @prishavall please resolve the conflicts and you can merge it in.

Note: the changes in .aws/task-definition.json are purely Prettier

farisdurrani commented 1 year ago

Good job

farisdurrani commented 1 year ago

Hey @prishavall can you solve the conflicts and merge this?