search

DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code
MIT License
24 stars 8 forks source link

[BUG]: Login With GitHub Not Working #923

Closed dwu359 closed 1 year ago

dwu359 commented 1 year ago

Operating system

MacOS Ventura 13.2.1

Bug description

Logging in with GitHub doesn't redirect me to the dashboard. Probably something to do with timer in _app.ts deleting the expect-user=true local storage object too early, but need to investigate further

Steps to reproduce

When attempting to login with Github in DLP on Firefox, it stays at the /login page

github-actions[bot] commented 1 year ago

Hello @dwu359! Thank you for submitting the Bug Request Form. We appreciate your contribution. :wave:

We will look into it and provide a response as soon as possible.

To work on this bug request, you can follow these branch setup instructions:

  1. Checkout the main branch:

     git checkout nextjs

  2. Pull the latest changes from the remote main branch:

     git pull origin nextjs

  3. Create a new branch specific to this bug request using the issue number:

     git checkout -b bug-923

    Feel free to make the necessary changes in this branch and submit a pull request when you're ready.

    Best regards, Deep Learning Playground (DLP) Team

karkir0003 commented 1 year ago

@dwu359 this problem doesn't hapen in chrome? just firefox and safari?

dwu359 commented 1 year ago

Yes, because Chrome is one of the only browsers that still allows third-party cookies by default I think, although that will start to change in 2024.