search

DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code
MIT License
24 stars 8 forks source link

[BUG]: Winget doesn't add dlp-cli path directly #949

Open dwu359 opened 1 year ago

dwu359 commented 1 year ago

Operating system

Windows

Bug description

This happened during pair prog on 9/7 on @Dashrekker's computer. @Dashrekker tried to install the dlp-cli with this cmd from the dlp-cli README (after init of dlp-cli submodule): winget install -m dlp-cli/manifests/d/DSGT-DLP/dlp-cli/0.0.11. Winget does install the dlp-cli, but it doesn't add the path properly to environment variables. @Dashrekker was able to resolve this by adding the path to the dlp-cli.exe manually to the path env var.

This seems like this is a current issue that winget is resolving: https://github.com/microsoft/winget-cli/pull/3002

What we can do ig is that we'll just have to modify the README stating the path env var to the winget installation location of dlp-cli that would need to be added for now.

Steps to reproduce

Follow the Windows installation instructions in the dlp-cli README

github-actions[bot] commented 1 year ago

Hello @dwu359! Thank you for submitting the Bug Request Form. We appreciate your contribution. :wave:

We will look into it and provide a response as soon as possible.

To work on this bug request, you can follow these branch setup instructions:

  1. Checkout the main branch:

     git checkout nextjs

  2. Pull the latest changes from the remote main branch:

     git pull origin nextjs

  3. Create a new branch specific to this bug request using the issue number:

     git checkout -b bug-949

    Feel free to make the necessary changes in this branch and submit a pull request when you're ready.

    Best regards, Deep Learning Playground (DLP) Team

karkir0003 commented 1 year ago

@dwu359 noah also resolved this?

karkir0003 commented 9 months ago

@dwu359 can this task be marked as deprioritized since we have scoop for windows install of dlp-cli