search

DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code
MIT License
24 stars 8 forks source link

[BUG]: Fix PyRight GitHub Action to Use Conda Environment #967

Closed dwu359 closed 10 months ago

dwu359 commented 1 year ago

Operating system

Whatever Operating System Github Actions use (linux?)

Bug description

Before running the pyright github action that runs a static type check on the backend, have it install the conda environment and poetry packages first.

Steps to reproduce

PyRight currently will complain about basically every python package rn bc it doesn't install the conda environment yet.

github-actions[bot] commented 1 year ago

Hello @dwu359! Thank you for submitting the Bug Request Form. We appreciate your contribution. :wave:

We will look into it and provide a response as soon as possible.

To work on this bug request, you can follow these branch setup instructions:

  1. Checkout the main branch:

     git checkout nextjs

  2. Pull the latest changes from the remote main branch:

     git pull origin nextjs

  3. Create a new branch specific to this bug request using the issue number:

     git checkout -b bug-967

    Feel free to make the necessary changes in this branch and submit a pull request when you're ready.

    Best regards, Deep Learning Playground (DLP) Team

karkir0003 commented 1 year ago

this should be fixed by the github action workflow revamp project @dwu359

karkir0003 commented 1 year ago

https://github.com/mamba-org/setup-micromamba

mamba setup github action

karkir0003 commented 1 year ago

https://github.com/mamba-org/setup-micromamba/issues/148

thread i created with micromamba to discuss cache v3 compatibility

karkir0003 commented 11 months ago

@dwu359 I updated the backend build check action to add poetry env to path before running pyright action. The changes are currently implemented in Prisha's PR (training-test-migration)