search

DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code
MIT License
26 stars 8 forks source link

[BUG]: Fix dlp-cli so that it has better regex for dlp env #988

Open dwu359 opened 1 year ago

dwu359 commented 1 year ago

Operating system

Noah's machine

Bug description

The dlp-cli will detect a false positive for a mamba env if the mamba env contains the string "dlp" in it, even if the env is named differently.

Steps to reproduce

Create a mamba env with a name containing "dlp", install backend via dlp-cli

github-actions[bot] commented 1 year ago

Hello @dwu359! Thank you for submitting the Bug Request Form. We appreciate your contribution. :wave:

We will look into it and provide a response as soon as possible.

To work on this bug request, you can follow these branch setup instructions:

  1. Checkout the main branch:

     git checkout nextjs

  2. Pull the latest changes from the remote main branch:

     git pull origin nextjs

  3. Create a new branch specific to this bug request using the issue number:

     git checkout -b bug-988

    Feel free to make the necessary changes in this branch and submit a pull request when you're ready.

    Best regards, Deep Learning Playground (DLP) Team

karkir0003 commented 1 year ago

@dwu359 this bug isn't just on Noah's machine. It seems to be across diff OS

dwu359 commented 1 year ago

Yep I know, that's just the OS where we discovered the bug, and it definitely isn't an OS dependent bug