DSGT-DLP / dlp-practice

Experimental practice repo for the original DLP repo for training purposes

MIT License

1 stars 4 forks source link

hartej (part 2) #10

Closed hartejsingh12 closed 7 months ago

hartejsingh12 commented 7 months ago

hartej (part 2)

Github Issue Number Here: <YOUR_GITHUB_ISSUE_NUMBER_HERE (include the hashtag)> What user problem are we solving?

What solution does this PR provide?

Testing Methodology How did you test your changes and verify that existing functionality is not broken

Any other considerations

Screen recording: https://www.youtube.com/watch?v=vcNmMt4-spQ

sweep-ai[bot] commented 7 months ago

Apply Sweep Rules to your PR?

[ ] Apply: All new business logic should have corresponding unit tests.
[ ] Apply: Refactor large functions to be more modular.
[ ] Apply: Add docstrings to all functions and file headers.

karkir0003 commented 7 months ago

Hey @hartejsingh12, there is an issue in the build check where you have two different, yet similar if conditions that lead to the same outcome. We should clean that up in order to get into the clean code habit

sonarcloud[bot] commented 7 months ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.7% Duplication

hartejsingh12 commented 7 months ago

Hey @hartejsingh12, there is an issue in the build check where you have two different, yet similar if conditions that lead to the same outcome. We should clean that up in order to get into the clean code habit

Fixed!

karkir0003 commented 7 months ago

@hartejsingh12 Good work on this. I'll be marking your PR as closed since we don't want to actually merge these changes into the real DLP app. Looking forward to your Part 3 PR