search

DSGT-DLP / dlp-practice

Experimental practice repo for the original DLP repo for training purposes
MIT License
1 stars 4 forks source link

andrew part3 #12

Closed andrewpeng02 closed 7 months ago

andrewpeng02 commented 7 months ago

Finished part3 of the practice repo

https://github.com/DSGT-DLP/dlp-practice/assets/47485510/f7b17b9e-5a63-408b-beec-6369d4554783

sweep-ai[bot] commented 7 months ago

Apply Sweep Rules to your PR?

sonarcloud[bot] commented 7 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

karkir0003 commented 7 months ago

looks good to me so far. very clean implementation!!!

@farisdurrani @dwu359 feel free to take a look when you get a chance

karkir0003 commented 7 months ago

we will not merge this change due to this pr relating to the beginner project though. we will simply close the pr if @farisdurrani and/or @dwu359 give the thumbs up