DSGT-DLP / dlp-practice

Experimental practice repo for the original DLP repo for training purposes

MIT License

1 stars 4 forks source link

mugdhesh-part3 #15

Closed MugPand closed 6 months ago

MugPand commented 7 months ago

Title of Pull Request HERE

Github Issue Number Here: <YOUR_GITHUB_ISSUE_NUMBER_HERE (include the hashtag)> What user problem are we solving?

What solution does this PR provide?

Testing Methodology How did you test your changes and verify that existing functionality is not broken

Any other considerations

https://github.com/DSGT-DLP/dlp-practice/assets/35412291/e6dd83ba-c902-42fa-8617-51dd54690906

sweep-ai[bot] commented 7 months ago

Apply Sweep Rules to your PR?

[ ] Apply: All new business logic should have corresponding unit tests.
[ ] Apply: Refactor large functions to be more modular.
[ ] Apply: Add docstrings to all functions and file headers.

sonarcloud[bot] commented 7 months ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

karkir0003 commented 6 months ago

@MugPand looks good to me. Great work on this PR. Code is very clean. We will not merge this PR in due to this task being in context of the beginner project. Looking forward to part 4 PR from you!

P.S: You don't need the Miniforge.sh and the AWSCLIV2 package files within the project repo