search

DSGT-DLP / dlp-practice

Experimental practice repo for the original DLP repo for training purposes
MIT License
1 stars 4 forks source link

Omansh #2

Closed Omanshb closed 8 months ago

Omanshb commented 8 months ago

This PR contains part 1 and part 2 of the beginner project for Omansh Bainsla.

karkir0003 commented 8 months ago

@Omanshb Can you please include detailed screen recording showing that the completion of Part 2 in the beginner project is giving the valid result?

sonarcloud[bot] commented 8 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.5% 0.5% Duplication

Omanshb commented 8 months ago

https://drive.google.com/file/d/1S4Qgzw9cP1T8yIaUem8Zo25yiuTdbZIp/view?usp=sharing

Here is a screen recording of all my part2 changes

karkir0003 commented 8 months ago

@Omanshb looks good to me. I'll close this PR since we don't want to merge this work into the actual DLP app