search

DSGT-DLP / dlp-practice

Experimental practice repo for the original DLP repo for training purposes
MIT License
1 stars 4 forks source link

Omansh-part3 #6

Closed Omanshb closed 8 months ago

Omanshb commented 8 months ago

Here are all of the changes I made for part 3 of the beginner project. I have also provided a screen recording for my functional endpoint.

https://drive.google.com/file/d/1mNUJW_1mDd0JA4TNmosEgteb8Z-2AHJD/view?usp=sharing

sweep-ai[bot] commented 8 months ago

Apply Sweep Rules to your PR?

sonarcloud[bot] commented 8 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

karkir0003 commented 8 months ago

@Omanshb great great work on this. I love how the code for this is very clean and shows understanding of the JS/TS client/server convention. Cool font by the way for the beginner.tsx file. Please read the other comments I included (they're non-blocking in terms of completion of part 3, but as helpful FYIs). I'll mark this PR as closed since we will not merge these changes into the real DLP app