search

DSGT-DLP / dlp-practice

Experimental practice repo for the original DLP repo for training purposes
MIT License
1 stars 4 forks source link

Lucas part2 #7

Closed LuHG18 closed 7 months ago

LuHG18 commented 8 months ago

Part 2 Fix

Github Issue Number Here: <YOUR_GITHUB_ISSUE_NUMBER_HERE (include the hashtag)> What user problem are we solving?

What solution does this PR provide?

Testing Methodology How did you test your changes and verify that existing functionality is not broken

Any other considerations

sweep-ai[bot] commented 8 months ago

Apply Sweep Rules to your PR?

sonarcloud[bot] commented 8 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.7% 2.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

LuHG18 commented 8 months ago

https://drive.google.com/file/d/1iuz_NByOislHfd_mKj8H1TAn7_3sO5b6/view screen recording of part 2

karkir0003 commented 7 months ago

@LuHG18 looks good to me. Thank you for this PR. Looking forward to your part 3 PR in the beginner project. I'll mark your PR as closed since we will not actually merge these changes into the real DLP app