search

DSGT-DLP / dlp-practice

Experimental practice repo for the original DLP repo for training purposes
MIT License
1 stars 4 forks source link

Michelle-part2 #8

Closed michellewliang closed 7 months ago

michellewliang commented 8 months ago

Michelle-part2

Github Issue Number Here: <YOUR_GITHUB_ISSUE_NUMBER_HERE (include the hashtag)> What user problem are we solving?

What solution does this PR provide?

Testing Methodology How did you test your changes and verify that existing functionality is not broken

Any other [considerations[] Screen recording: https://drive.google.com/file/d/1mPYYrHbiHZWkrujtOjM_omtd6OEHqojV/view?usp=drive_link

sweep-ai[bot] commented 8 months ago

Apply Sweep Rules to your PR?

sonarcloud[bot] commented 8 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

karkir0003 commented 7 months ago

@michellewliang is the screen recording updated?

karkir0003 commented 7 months ago

@michellewliang recording looks good. Good work on Part 2. Looking forward to your part 3 PR

karkir0003 commented 7 months ago

I'll close your PR for now since we don't actually want to merge these changes into the real DLP app.