search

DSGT-DLP / dlp-practice

Experimental practice repo for the original DLP repo for training purposes
MIT License
1 stars 4 forks source link

nishant-part2 #9

Closed bagnishant closed 7 months ago

bagnishant commented 7 months ago

nishant-part2

Github Issue Number Here: #1 What user problem are we solving? Completing the scavenger hunt (part 2).

What solution does this PR provide? Renamed the nav bar item "Train" to "Hello World", renamed "Donate" link to "Custom Link" and linked to YouTube video, added font-awesome React logo, added dummy radio button in parameters step for tabular training, renamed "Start" to "Beginning" in parameters for tabular training, console logged user's email on login, logged trainspace name when user submitted trainspace for training.

Testing Methodology Ran frontend and backend locally and ensured that each part of the scavenger hunt showed up as expected.

Any other considerations Screen recording: https://youtu.be/IHrriEiJ0dQ

sweep-ai[bot] commented 7 months ago

Apply Sweep Rules to your PR?

sonarcloud[bot] commented 7 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
4.4% 4.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

karkir0003 commented 7 months ago

@bagnishant looks good to me. Thank you for this. looking forward to your part 3 PR. im marking this PR as closed since we don't want to merge these changes into the real DLP app