DSaurus / threestudio-dreamcraft3D

58 stars 1 forks source link

checkpoint from texture refinement stage is a symbolic link to itself #11

Closed markkurt closed 10 months ago

markkurt commented 10 months ago

ls -al outputs/dreamcraft3d-texture/a_mans_face\,_frontview\@20231227-201844/ckpts/last.ckpt

lrwxrwxrwx 1 root root 101 Dec 27 20:46 outputs/dreamcraft3d-texture/a_mans_face,_frontview@20231227-201844/ckpts/last.ckpt -> /root/threestudio/outputs/dreamcraft3d-texture/a_mans_face,_frontview@20231227-201844/ckpts/last.ckpt

(the symbolic link points to itself)

When using that checkpoint for model export the error reported is: OSError: [Errno 40] Too many levels of symbolic links: 'outputs/dreamcraft3d-texture/a_mans_face,_frontview@20231227-201844/ckpts/last.ckpt'

markkurt commented 10 months ago

changing the last line of the texture config: https://github.com/DSaurus/threestudio-dreamcraft3D/blob/master/configs/dreamcraft3d-texture.yaml#L148 to match the last line of the other configs worked to fix this issue for me: https://github.com/DSaurus/threestudio-dreamcraft3D/blob/master/configs/dreamcraft3d-geometry.yaml#L132

i.e., changing: every_n_train_steps: 0 to every_n_train_steps: ${trainer.max_steps}

DSaurus commented 10 months ago

Hi, @markkurt ,

Thank you for finding this bug. I have fixed it in commit 256c9a7.

markkurt commented 10 months ago

thanks!