DSchroer / dslcad

DSLCad is a programming language & interpreter for building 3D models.
https://dslcad.com
GNU Lesser General Public License v2.1
470 stars 14 forks source link

UI scale factor not used on Kubuntu/KDE #4

Closed virtualritz closed 1 year ago

virtualritz commented 1 year ago

I wager this is coming from bevy as when I run a 'normal' egui/eframe app, the UI is scaled correctly.

But in case of DSLCAD it uses 1.0 (my system uses 1.5). When DSLCAD starts, winit says the usual (correct):

2023-02-10T18:04:19.605215Z  INFO winit::platform_impl::platform::x11::window: Guessed window scale factor: 1.5 

But everything is tiny, i.e. the actual UI definitely uses 1.0, not 1.5.

DSchroer commented 1 year ago

Interesting. Ill try it out on my machine and see if I can get the UI to scale correctly. If it doesn't ill be sure to push a fix. Thank you for the bug report.

mjecke commented 1 year ago

Just wanted to add that something like this seems to also be true on Mac. The UI titlebar upon launch is tiny tiny tiny on a retina display. Here is what is reported upon launch for my system:

2023-02-10T22:02:19.479160Z INFO bevy_render::renderer: AdapterInfo { name: "Apple M1 Pro", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }

DSchroer commented 1 year ago

Hey. I have pushed a new pre-release that should fix the UI scaling issues. Can you give it a try?

https://github.com/DSchroer/dslcad/releases/tag/v0.0.2-pre.1

mjecke commented 1 year ago

That indeed fixed the UI scaling on my Mac. Toolbar looks correctly sized now

image
DSchroer commented 1 year ago

Closing as resolved.