search

DSheirer / sdrtrunk

A cross-platform java application for decoding, monitoring, recording and streaming trunked mobile and related radio protocols using Software Defined Radios (SDR). Website:
GNU General Public License v3.0
1.59k stars 256 forks source link

No audio after gradle compile on Windows #307

Closed endorphinrush closed 6 years ago

endorphinrush commented 6 years ago

Not a bug just a suggestion.

If following "Build the project" instructions, sdrtrunk produces no audio. This is not resolved until adding jmbe back to <../build/libs>.

<This would add gradle, download all project dependencies and build JAR>

Would this be considered a dependency that should be installed during build? If not another line might be useful to indicate the additional dependency needs.

DSheirer commented 6 years ago

The JMBE audio library is excluded from the normal build (and release) process due to potential copyright restrictions. We leave it to the end-user to compile JMBE and co-locate the library in the execution folder to enable P25 audio decoding.

endorphinrush commented 6 years ago

No problem, I get that. It was just a suggestion for the readme file. Thanks for the hard work!

chudgoo commented 6 years ago

Would there be anything wrong with including a routine that checks for JMBE and fetches/installs if needed? You're not including the code itself in your software, but could provide an automated way for it to be compiled. Maybe a prompt like "are you sure you agree to the terms of the third party EULA? Seems fairly safe from a legal standpoint.... I think... ???

On Mon, Jan 1, 2018 at 6:42 AM, Denny Sheirer notifications@github.com wrote:

The JMBE audio library is excluded from the normal build (and release) process due to potential copyright restrictions. We leave it to the end-user to compile JMBE and co-locate the library in the execution folder to enable P25 audio decoding.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DSheirer/sdrtrunk/issues/307#issuecomment-354651484, or mute the thread https://github.com/notifications/unsubscribe-auth/ASl2zatDXUtCeSxCTTGhAvxPKEbuPWG6ks5tGNLHgaJpZM4RP5kc .