search

DSpace-Labs / angular2-ui-prototype

(OBSOLETE: Use https://github.com/DSpace/dspace-angular) Ongoing work on Angular UI has moved to DSpace/dspace-angular
https://github.com/DSpace/dspace-angular
Other
7 stars 10 forks source link

Swap out bootstrap for angular material #2

Open artlowel opened 8 years ago

artlowel commented 8 years ago

https://material.angularjs.org

wellingWilliam commented 8 years ago

https://github.com/angular/material2

ghost commented 8 years ago

Material for Angular2 is still in alpha. Would be a continual task to piece in the components until a beta release. Depends on the timeline. Adding Material might make for a worse demo in 7 weeks, rather than using bootstrap.

tdonohue commented 8 years ago

FWIW, I'm not sure that we need to be using Angular Material in order to sufficiently test SEO (which is our first goal). From talking with Anurag at Google Scholar in past, it sounds like they mostly care about two things:

  1. That the same (or very similar) HTML is generated on both client-side and server-side.
    • This seems to be the case so far. Even now, if I turn off JS and view the HTML, it looks identical to when I have JS turned on. But, obviously we'll test this further via the prototype.
    • However, the user experience is obviously different, since with JS turned off, Bootstrap doesn't load. But, I'm not sure that actually matters to Google Scholar (or if they even attempt to detect it), since all they are indexing is the HTML.
  2. That all the primary indexable content can be provided via server-side rendering.
    • This also seems to be the case so far. Again, obviously we'll test this further via this prototype.

So, I think we should be able to move forward with using Bootstrap for now (unless we hit upon specific SEO issues that I'm overlooking). However, we can keep this ticket open and revisit it once Material for Angular2 is further along (as it might be the better long term solution).

artlowel commented 8 years ago

I agree it is completely irrelevant for the Google Scholar tests. I created this ticket because I thought it would be simple, and we'd better swap them early on to ensure we wouldn't have to adapt too many templates afterwards. But if the project is still in alpha we're better off staying with bootstrap for now.

artlowel commented 8 years ago

Closed it before I read Tim's last comment

However, we can keep this ticket open and revisit it once Material for Angular2 is further along (as it might be the better long term solution).

So I reopened it.

ghost commented 8 years ago

I used Material for Angular and I really liked it. I believe the Google timeline on this is for the beta of Material for Angular 2 to be released when the first release of Material for Angular 1 is finished. Bootstrap is coming out with there 4th version. It will be using flex for responsive design similar to Angular Material. I like both but I think Material 2 will make for a better integration and will be a more original UI experience. Bootstrap has become boring.

wellingWilliam commented 8 years ago

Here is an example of how we would have to bring in Material for Angular2: https://github.com/AngularClass/angular2-webpack-starter/blob/master/package.json

tdonohue commented 8 years ago

We discussed this during the meeting on April 21 and decided to stick with Bootstrap for now. Material for Angular2 is not very far along yet, has fewer available out-of-the-box themes, and is less familiar to the DSpace community. So, at least for OR16 demo, we'll stick with Bootstrap.