search

DSpace / DSpace

(Official) The DSpace digital asset management system that powers your Institutional Repository
https://wiki.lyrasis.org/display/DSDOC8x/
BSD 3-Clause "New" or "Revised" License
904 stars 1.32k forks source link

[DS-2425] Typos in xoai.xml prevent filters from being used #5786

Closed dspace-bot closed 9 years ago

dspace-bot commented 9 years ago

Imported from JIRA [DS-2425] created by christian.scheible

in the xoai.xml file starting at line 217 there are typos for all 4 conditions.
it should be titleExistsCondition, authorExistsCondition, driverDocumentTypeCondition and openaireRelationCondition instead of ...Filter.

dspace-bot commented 9 years ago

tdonohue said:

Here's the code that is referenced:

https://github.com/DSpace/DSpace/blob/master/dspace/config/crosswalks/oai/xoai.xml#L217

Sure enough, these conditions all end in "*Filter" rather than "*Condition".

This seems like something that could be quickly fixed, so I'm scheduling for 5.1

dspace-bot commented 9 years ago

helix84 said:

Pull request:
https://github.com/DSpace/DSpace/pull/845

dspace-bot commented 9 years ago

helix84 said:

Fixed in master (for 6.0) and dspace-5_x (for 5.1).