DSpace / DSpace

(Official) The DSpace digital asset management system that powers your Institutional Repository
https://wiki.lyrasis.org/display/DSDOC8x/
BSD 3-Clause "New" or "Revised" License
888 stars 1.31k forks source link

Fixed too long classpath bug in test_databaseFixed classpath issue in test_database target #9539

Closed jeffmorin closed 3 months ago

jeffmorin commented 4 months ago

References

Description

In the original state of the test_database target in build.xml, the classpath built within the task becomes too long to be properly handled by the <java> task that follows, which causes failure of any task that includes test_database. I fixed the task so that the classpath is stored in an alias that is then used in the <javac> task, which doesn't fail anymore.

Instructions for Reviewers

After building the project using Maven, run fresh_install (or any task that has test_database in its transitive dependencies) in /dspace/target/dspace-installer/build.xml.

List of changes in this PR:

Please note that I am not sure whether this behaviour will be reproducible in all environments. I work in a Windows 10-based environment.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

Please note that unchecked entries below are not applicable to non-Java files.

dspace-bot commented 3 months ago

Successfully created backport PR for dspace-7_x:

mwoodiupui commented 3 months ago

A 2kB CLASSPATH is not particularly long for a large project, alas! I got into a DSpace instance's 'lib/' directory and ran 'ls | wc'. That instance's 180 required JARs have names adding up to 4311 bytes (including space delimiters).