DSpace / DSpace

(Official) The DSpace digital asset management system that powers your Institutional Repository
https://wiki.lyrasis.org/display/DSDOC8x/
BSD 3-Clause "New" or "Revised" License
888 stars 1.31k forks source link

submitter facet unnecessary for archived items #9660

Open floriangantner opened 3 months ago

floriangantner commented 3 months ago

Is your feature request related to a problem? Please describe. During indexing the item for the search the submitter information is saved in some own facet

https://github.com/DSpace/DSpace/blob/075e51d4d8ad675f029a1d6af6ea249e04b5781d/dspace-api/src/main/java/org/dspace/discovery/indexobject/ItemIndexFactoryImpl.java#L158

Knowing administrative and curative staff of some repository allows you to track certain people (e.g. by their surname). e.g.

https://tore.tuhh.de/search?spc.page=1&query=submitter_keyword:Oliver*&configuration=site ` (DSpace-Cris)

https://depositonce.tu-berlin.de/search?spc.page=1&query=submitter_keyword:Maximilian* (DSpace7)

https://sandbox.dspace.org/search?spc.page=1&query=submitter_keyword:%22Demo%20Site%20Administrator%22 (Dspace8 Sandbox)

Query: submitter_keyword:"Demo Site Administrator"

Screenshot 2024-06-20 at 11-32-06 DSpace Repository Search

Describe the solution you'd like The submitter information is currently never used after the information is archived. Contents in metadatafield dc.description.provenance (containing the submitter) is not exposed and not indexed by default.

We would like some additional configuration to disable the submitter facet for archived items and also some optional configuration setting to set some placeholder value instead name (e.g. John, Doe).

discovery.index.item.submitter.enabled (boolean, default false) discovery.index.item.submitter.name (string, default null)

Describe alternatives or workarounds you've considered The submitter_authority might be needed if you define some own discovery configuration which displays archived items for some eperson in mydspace. Thus we would prefer the configuration possibility to enable repository developers to still use submitter_authority.

Additional context The submitter information is also indexed for inprogressItems where it is needed for the submitter Facet on workflow search configurations. The feature does not impact this facet

https://github.com/DSpace/DSpace/blob/075e51d4d8ad675f029a1d6af6ea249e04b5781d/dspace-api/src/main/java/org/dspace/discovery/indexobject/InprogressSubmissionIndexFactoryImpl.java#L64

We can offer some solution for this issue.

tdonohue commented 3 months ago

Needs volunteer. Loosely related to https://github.com/DSpace/dspace-angular/issues/2950 because that ticket is related to who can see submitter information. It's possible the two could be fixed at the same time.

floriangantner commented 2 months ago

@tdonohue i can provide some solution for this issue It's also related to the problem described here https://github.com/DSpace/DSpace/issues/9419#issuecomment-2008090290

tdonohue commented 2 months ago

Thanks @floriangantner ! I'll assign this to you then to work on. Feel free to submit ideas or a PR whenever you are ready.