search

DSpace / RestContract

REST Contract for DSpace 7-8
https://wiki.lyrasis.org/display/DSDOC8x/
37 stars 48 forks source link

Document how to create an item request, and how to accept or reject one #173

Closed mwoodiupui closed 2 years ago

mwoodiupui commented 2 years ago

This was consolidated with #172 as requested.

Describes https://github.com/DSpace/DSpace/pull/2129

artlowel commented 2 years ago

There is a final feature in the regular (non-helpdesk) workflow that's still not supported as far as I can see.

If you grant a request, you get the option to ask the admins to change the permissions of the item:

change permissions

I've asked Yana to go ahead and create that UI page already, in case we can still get the rest work done in time. If we can't, we can easily disable the page for 7.1.

mwoodiupui commented 2 years ago

I don't see why we ask for the name and e-mail on the "change permissions" page, since one must be logged in to grant a request, and thus we know the name and e-mail already. Perhaps this should be reduced to an explanatory paragraph and a checkbox on the accept/reject form, where the checked status can be sent in the same PUT that sets the acceptance status. It will still need support from the REST layer.

artlowel commented 2 years ago

I agree, a checkbox would be better

tdonohue commented 2 years ago

Merging as implementation PR is complete & merged https://github.com/DSpace/DSpace/pull/2129