Closed kshepherd closed 7 months ago
@tdonohue i have addressed all review feedback for this feature and @MW3000 has tested the dspace and angular features successfully. The PRs are still waiting on a second approval. Are we able to get another review in for this feature?
I have moved duplicates to a separate controller and documented it as such (see also: REST and angular PRs as linked in description). I have also shifted solr work so it just uses an existing non-tokenized field instead of introducing a _signature field to avoid confusion and conflict. If the endpoint name should also be changed to avoid confusion or conflict with 4science work coming in the future let me know, the endpoint name/path is of no consequence to me.
Hi @kshepherd, Conflicts have been detected against the base branch. Please resolve these conflicts as soon as you can. Thanks!
@tdonohue applied changes and rebased -- i added duplicates.md to the main section of endpoints.md since if this is merged, it will not be experimental/under discussion
Pushed update with new notes about get single / get all not being implemented, and the new search path
Adds REST contract descriptions for the Duplicate Detection feature, which has active PRs.
The initial work on this feature was supported by TU Berlin. This work was supported by FHNW and ZHAW.
Related PRs:
Backend: https://github.com/DSpace/DSpace/pull/9265 Frontend: https://github.com/DSpace/dspace-angular/pull/2749 Replaces: https://github.com/DSpace/RestContract/pull/198
The changes are made to
items.md
(new item link) andworkspaceitems.md
(new submission section), with the example data provided in a newworkspaceitem-data-duplicates.md
file.