search

DSpace / RestContract

REST Contract for DSpace 7-8
https://wiki.lyrasis.org/display/DSDOC8x/
38 stars 48 forks source link

Project instead of funding mentionment in ORCID synchronization preferences #255

Closed floriangantner closed 5 months ago

floriangantner commented 7 months ago

Please describe your request The contract mentions some /api/eperson/profiles/<:eperson-uuid>/orcid/projects endpoint which does not exist. https://github.com/DSpace/RestContract/blob/7906b33b3020a96b108f27a8b10b1db8de028517/profiles.md?plain=1#L238

The corresponding file mentions some /fundings path instead.

https://github.com/DSpace/DSpace/blob/28ad35f858131901dfe3108dcae57ea7328218e3/dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/patch/operation/ResearcherProfileReplaceOrcidSyncPreferencesOperation.java#L57

In Addition the ResearcherProfile Rest OrcidSynchronization setting https://github.com/DSpace/RestContract/blob/7906b33b3020a96b108f27a8b10b1db8de028517/profiles.md?plain=1#L28
should return some fundingsPreference instead of the projectsPreference

https://github.com/DSpace/DSpace/blob/28ad35f858131901dfe3108dcae57ea7328218e3/dspace-server-webapp/src/main/java/org/dspace/app/rest/converter/ResearcherProfileConverter.java#L61C18-L61C19

https://github.com/DSpace/DSpace/blob/28ad35f858131901dfe3108dcae57ea7328218e3/dspace-server-webapp/src/main/java/org/dspace/app/rest/model/ResearcherProfileRest.java#L94

We provide some PR fixing this.