DSpace / dspace-angular

DSpace User Interface built on Angular.io
https://wiki.lyrasis.org/display/DSDOC8x/
BSD 3-Clause "New" or "Revised" License
122 stars 401 forks source link

[Deque Analysis] On homepage of "dspace" theme, text over image has insufficient color contrast #1157

Open tdonohue opened 3 years ago

tdonohue commented 3 years ago

Deque Analysis Summary

On homepage, text over image has insufficient color contrast (both for the regular text and the green hyperlinks).

https://demo7.dspace.org/home

  1. Regular white text: "Text content lacks 4.5:1 contrast ratio. Text color:#FFFFFF Background color: #8C8C8C Contrast ratio: 3.4:1"
    • Deque issue ticket IDs: 469494
  2. Green link text: "Text content lacks 4.5:1 contrast ratio. Link text color: #92C642 Background color: #8C8C8C Contrast ratio: 1.7:1"
    • Deque issue ticket IDs: 469540
  3. Green link text (on hover over): "Text content lacks 4.5:1 contrast ratio. Link text color: #68902B Background color: #163B51 Contrast ratio: 1.7:1"
    • Deque issue ticket IDs: 469550
  4. Green link text is not sufficiently differentiated by color from white text. "Link text and static text are differentiated only by color. The contrast ratio between default link text and surrounding text is not at least 3:1."
    • Link text color: #92C642, Surrounding text color: #FFFFFF, Contrast ratio: 2:1
    • Fix is either to underline or outline links (to differentiate) or increase contrast.
    • Deque issue ticket IDs: 469548
  5. "Photo by" small text: "Text content lacks 4.5:1 contrast ratio. Text color: #58707E (opacity 0.3 on defined color: #FFFFFF) Background color: #113246 Contrast ratio: 2.6:1"
    • Deque issue ticket IDs: 469544

Recommended Fix

We may need to darken the background overlay image We may also need to consider making the green links lighter, or replacing them altogether with a different lighter color. The "photo by" text is not important for the page. It could be lightened though to make it slightly more visible. Or, we could remove it (or move it into code comments in our "dspace" theme itself) as Pexels.com doesn't require it https://www.pexels.com/license/

Other ideas are welcome, as I admit this is a bit of a complex scenario.

More Information / Tools

tdonohue commented 3 years ago

@artlowel : Assigning this to you for analysis, as it's all about the homepage image & overlay text. As you'll see above, I have a few early ideas for how to fix accessibility, but I'm open to other ideas here. (And we might need to remove the green link color if it's just too difficult to deal with)

vtThomaz commented 2 months ago

Good afternoon! I'm Victor Ferreira and I work at Neki-IT, I would like to request the activity for us, as we are already working on it. When the Pull Request is made, should it be made to the last branch of dspace-7_x or to the main branch?

tdonohue commented 2 months ago

@vtThomaz : Thanks for volunteering. I'll assign this to you. I'd recommend creating a PR against main if possible, simply because it has stricter lint rules... so it's easier to backport a fix from main to dspace-7_x than it is to port a fix from dspace-7_x to main.