DSpace / dspace-angular

DSpace User Interface built on Angular.io
https://wiki.lyrasis.org/display/DSDOC8x/
BSD 3-Clause "New" or "Revised" License
132 stars 433 forks source link

Media viewer controls rendered behind DSpace header #2341

Closed ybnd closed 12 months ago

ybnd commented 1 year ago

Describe the bug The preview of ngx-gallery is rendered behind the DSpace header, which obscures its controls, including the "Close" button. Because of this, the preview can only be closed by

To Reproduce Steps to reproduce the behavior:

  1. Open (or create) an Item with multiple images in the ORIGINAL Bundle
  2. Click on the media viewer placeholder to open th preview

Expected behavior The preview should be drawn over top of the header.

Solutions Can be solved here by either

However, these changes are incompatible with mobile view (see https://github.com/DSpace/dspace-angular/pull/2220)

HamzaFarooqArif commented 1 year ago

I want to work on it. please assign it to me

tdonohue commented 1 year ago

Thanks again @HamzaFarooqArif for volunteering!

HamzaFarooqArif commented 1 year ago

I apologize that I'll not be able to continue working on it. I'm unassigning me from this issue

tdonohue commented 1 year ago

Additional details from duplicate ticket #2429 created by @Sondissimo :

Describe the bug When we select an item, if we open the bitstream to visualize it, we encounter a strange behaviour regarding the top navbar. Version: 7.6

To Reproduce Steps to reproduce the behavior:

  1. When we visualize an item bitstream the navbar is not correctly rendering image

Expected behavior The navbar shouldnt be visible when inspecting bitstreams

Related work https://github.com/DSpace/DSpace/issues/9022

tdonohue commented 1 year ago

Assigning to @Sondissimo who volunteered on behalf of 4Science.

davide-negretti commented 1 year ago

I'm now working on this one in place of @Sondissimo

davide-negretti commented 1 year ago

I opened a PR: #2594