search

DSpace / dspace-angular

DSpace User Interface built on Angular.io
https://wiki.lyrasis.org/display/DSDOC8x/
BSD 3-Clause "New" or "Revised" License
131 stars 429 forks source link

sub-collection-list and sub-community-list components don't use communityList.pageSize as indicated in docblocks #2592

Open ddean4040 opened 11 months ago

ddean4040 commented 11 months ago

Describe the bug The docblocks for pageSize in community-page-sub-collection-list.component.ts and community-page-sub-community-list.component.ts indicate that the default value comes from communityList.pageSize.

Changing communityList.pageSize has no effect on the page size on these pages.

To Reproduce Steps to reproduce the behavior:

  1. Change the value of communityList.pageSize in the site config (env or config.yml)
  2. Check a community page with subcommunities and subcollections - the default page size is not changed

Expected behavior Default page size should change

tdonohue commented 11 months ago

@ddean4040 : I'll admit, I'm not sure what those comments are even saying. I don't know whether they are implying that communityList.pageSize should work, or if they are saying it should NOT work because the component always overrides that config.

Regardless, I agree it's odd behavior. I'll leave this open and move to our maintenance board in search of a volunteer.

That said, I'm not sure if the solution should be for the communityList.pageSize to control these page sizes, as that configuration was created to control the /community-list page (e.g. https://demo.dspace.org/community-list). Instead, we might need to determine whether there should be a similar pageSize element on the Community Homepage.

ddean4040 commented 11 months ago

@tdonohue - Fair enough and thanks for looking into it :)

alanorth commented 10 months ago

As of DSpace 7.6 we currently have:

I don't know what the settings should be called, but I think having a configurable page size for sub-community and sub-collection lists is reasonable.

Note: I see that the custom theme themes the communityPage component as well as the community-page-sub-community-list and community-page-sub-collection-list components. It should be possible to override the pageSize then...