search

DSpace / dspace-angular

DSpace User Interface built on Angular.io
https://wiki.lyrasis.org/display/DSDOC8x/
BSD 3-Clause "New" or "Revised" License
126 stars 416 forks source link

Consider update of ng-dynamic-forms library to latest version #3226

Open saschaszott opened 1 month ago

saschaszott commented 1 month ago

Problem Description

The submission form implementation in DS7 (and DS8) depends on the ng-dynamic-forms library. The current version of this library is 18 (released in mid of 2023). DS8 depends on version 16 (released in december 2022).

Note: There is / was some discussion about a replacement of the ng-dynamic-forms library in DS8. Some developers noted that this change would require a large amount of work. Perhaps it is easier to update the version of the ng-dynamic-forms library.

tdonohue commented 1 month ago

While I'm not against an upgrade, I think this doesn't "fix" the issues mentioned in #2216. The issue is that @ng-dynamic-forms is not being well maintained (even now, it's not yet updated to Angular 17 support, which is what DSpace 8 uses). So, this ticket could provide a way to temporarily improve ng-dynamic-forms by upgrading it. But, in the long term it's still better to find a way to migrate to Angular's own forms library.

So, I'll pull this over to the 9.0 board in case someone wants to work on this until we find a way to fix #2216.