search

DSpace / dspace-angular

DSpace User Interface built on Angular.io
https://wiki.lyrasis.org/display/DSDOC8x/
BSD 3-Clause "New" or "Revised" License
135 stars 436 forks source link

Bitstreams must always open in new tab #3657

Open erpnedir opened 1 week ago

erpnedir commented 1 week ago

Currently, bitstreams open in the main window if the file size is below the threshold value. It would be better to open it in a new tab.
Users go back and forth. As the bitstream and metadatas may differ, it would be better to see both at the same time in different tabs.

Some discussion may be seen on mail thread: https://groups.google.com/g/dspace-community/c/6DzqJsv2mcI/m/lmKlvI-xBgAJ

alanorth commented 1 week ago

Hi @erpnedir. I noticed this change in behavior when we migrated to DSpace 7. I filed an issue on the backend last year: https://github.com/DSpace/DSpace/issues/8900

erpnedir commented 1 week ago

Hi @alanorth I understand that your issue proposes to open the bitstream inline instead of download. We can achive this by configuring a high value to the threshold parameter webui.content_disposition_threshold. I offer to open it in browser always in a new tab. The users we talk go back and forth among the pdf and item page. That creates a bad user experience. If that behaviour (opening the bitstream on the same page) has any benefit to user, this can be done by a parameter. But if there is no benefit of the user, I think that bitstreams must always open in new tab of browser if the file size is below the threshold value.

alanorth commented 6 days ago

@erpnedir Ah yes you are right, I filed that issue over a year ago and forgot that it's slightly different. The bug is with the content-disposition header behaving differently in DSpace 7.

Regarding your suggestion to always open bitstreams in a new window, we should get more feedback from other repository administrators to see if their users feel the same. Currently the only links that DSpace opens in a new window are those that are external to the site (for example DOIs or other external links on the item view page).