Downloading multiple files as a zip fails

DSteve595 / Put.io

Put.io for Android!

MIT License

141 stars 30 forks source link

Downloading multiple files as a zip fails #43

Closed GeorgeHahn closed 6 years ago

GeorgeHahn commented 8 years ago

When downloading multiple files, if zip is chosen, the downloaded file is a JSON document with the following format, rather than the selected files:

{
"status": "OK",
"zip_id": 0000000
}

DSteve595 commented 8 years ago

More API changes by put.io without anyone being notified, lol. I'll get to it as soon as I can.

On Wed, Feb 17, 2016, 10:44 AM George Hahn notifications@github.com wrote:

When downloading multiple files, if zip is chosen, the downloaded file is a JSON document with the following format, rather than the selected files:

{"status": "OK","zip_id": 0000000 }

— Reply to this email directly or view it on GitHub https://github.com/DSteve595/Put.io/issues/43.

GeorgeHahn commented 8 years ago

Looking at the documentation around zip downloading, I think I might be able to tackle this one.

Essentially, PutioUtils lines 355 and 360 need to parse the downloaded file for the zip ID and then return a download call on that URL.

The things I'm not sure about are:

How should I download the zip ID without actually storing it as a file?
How should I handle parsing the JSON response?

Cheers!

DSteve595 commented 7 years ago

Sorry, this shouldn't have been closed. @GeorgeHahn Apologies for missing your comment, would you still want to take a crack at it? I can help with any questions you have (including those two, if they're still relevant). If not, I'll work on it after some bug fixes.

DSteve595 commented 6 years ago

Fixed as of 4.2 beta 2.