search

DSteve595 / Put.io

Put.io for Android!
MIT License
141 stars 30 forks source link

Multiple code improvements - squid:S1118, squid:S2259 #47

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S1118 - Utility classes should not have public constructors. squid:S2259 - Null pointers should not be dereferenced. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1118 https://dev.eclipse.org/sonar/rules/show/squid:S2259 Please let me know if you have any questions. George Kankava

DSteve595 commented 8 years ago

I like some of these changes, but there are few merged if-statements that I'd like to keep separated for now (to make it easier to add future logic). If you wouldn't mind, could you revert the changes in BaseCastActivity, Putio, FileDetails, Files, and FilesAndFileDetails? I'll merge after that.

georgekankava commented 8 years ago

@DSteve595 Updated.