search

DSteve595 / Put.io

Put.io for Android!
MIT License
141 stars 30 forks source link

Multiple code improvements - squid:S1854, squid:S1068, squid:S1481, squid:S1764 #48

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S1854 - Dead stores should be removed. squid:S1068 - Unused private fields should be removed. squid:S1481 - Unused local variables should be removed. squid:S1764 - Identical expressions should not be used on both sides of a binary operator. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1854 https://dev.eclipse.org/sonar/rules/show/squid:S1068 https://dev.eclipse.org/sonar/rules/show/squid:S1481 https://dev.eclipse.org/sonar/rules/show/squid:S1764 Please let me know if you have any questions. George Kankava

DSteve595 commented 8 years ago

Hey, I'm really sorry this took so long to get to.

Some of the unused variables I wanted to leave there in case of them being used later (like the media scale, error reason, and subtitle URL), so I'm not sure I'd want to get rid of those just yet. I like the changes in Files, PutioTransferFileUploadResponse, PutioTransfer, and TvGridFragment. I'll merge if the others are reverted.

georgekankava commented 8 years ago

@DSteve595 Hi. Sure NP. Changes applied.