search

DSteve595 / Put.io

Put.io for Android!
MIT License
141 stars 30 forks source link

Plain HTTP URL in gradle #69

Open IzzySoft opened 5 years ago

IzzySoft commented 5 years ago

F-Droid's lint just complained about a plain HTTP URL in your build.gradle. Guess a fix should be as easy as adding an 's' to make it https:// – but I'm no Android dev. Could you please fix that? Thanks!

DSteve595 commented 5 years ago

Could be, I'll try in a bit! What's running the linter?

IzzySoft commented 5 years ago

GitLab CI (after a push); I'm just in another run with metadata improvements, and your app was in that batch (some URL fixups). It's no show-stopper for F-Droid (as we don't pull in dependencies that way), so it's rather along the lines of "you might wish to know" :wink:

DSteve595 commented 5 years ago

A little confused, why is this app being built for F-Droid? I'm definitely cool with having it listed there, but I was under the impression that I'd have to submit it.

IzzySoft commented 5 years ago

Obviously it was submitted – which usuallys means the author has agreed (well, you did now – but usually we build only after the author's OK). Le me check … Ah, there it is, 4 years ago – which rather sounds like it wasn't enabled. And that's what it is: Metadata are there, but the app is not enabled so it won't show up.

As it seems you'd like to see it there, shall we go after that? Back then it was disabled due to …

Upstream uses proprietary dependencies like Google Play Services etc.

A quick glance at your app's build.gradle shows me there's fabric, firebase, GMS, Crashlytics; each one of those is a show-stopper (not 100% sure for fabric, but the rest is). So could you provide a build flavor that comes without them?

Meanwhile, your app is available in my repo (picking the APK from releases/ – an APK with no or at least less trackers would be welcome there, too). If we can get rid of all those show-stoppers, it could be moved over to the main repo.

Just let me know when you do anything in that regard. In the ideal case, we can open an issue to have your app activated in the official repo. Until then, I maybe could pick some Putio_noanalytics.apk from releases/, which at least has no Firebase(Analytics)/Crashlytics?

DSteve595 commented 5 years ago

When I have a bit of time, I'll start work on a flavor without that functionality.

IzzySoft commented 5 years ago

Please let me know when there's something to pick. I gladly help bringing your app into the official repo if possible – or update mine with the new flavor. Thanks for caring!