search

DTS-STN / digital-dojo-engagement

Digital Dojo 2.0 application
https://digital-dojo-engagement-main.bdm-dev.dts-stn.com/
Other
0 stars 1 forks source link

612 create an faq page #32

Closed andr0272 closed 2 years ago

andr0272 commented 2 years ago

ADO-612

Description

List of proposed changes:

-Added FAQ page -Added an accordion component for expanding FAQ sections

What to test for/How to test

Pull the code, run it, compare the game to

Additional Notes

the target: pseudo class that highlights the question if directly linked to doesn't seem to work. I will bring it up during a standup

github-actions[bot] commented 2 years ago

Integration Deployment :rocket: - Check build status Jest Coverage Report GitHub Workflow Status Cypress Coverage Report GitHub Workflow Status

Fbasham commented 2 years ago

Looks like the e2e tests are failing because axe is flagging accessibility issues. The problem is that for some reason, the Navbar links fail colour contrast:

image

Fbasham commented 2 years ago

The global.css has to be changed to conform to colour contrast minimums. https://www.w3.org/TR/WCAG21/#contrast-minimum

Basically the anchor tags need to have a contrast ratio of 4.5:1 for the comparison between foreground text and background colour in all states (unvisited/visited). This can be tested using a colour contrast analyzer either in a browser, or a piece of software called Colour Contrast Analyzer.

image