search

DTS-STN / secure-client-hub

Beta authenticated client application for accessing benefits
MIT License
2 stars 2 forks source link

Update footer ternary to use publicRuntimeConfig value #705

Closed krischarbonneau closed 2 months ago

krischarbonneau commented 2 months ago

ADO-249261

Fixed AB#249261

Changelog

fix:Update ternary in footer component to use publicRuntimeConfig fix:Add OTEL jaeger dependency to fix local errors

Description of proposed changes:

This PR updates the ternary operation for our footer links to use publicRuntimeConfig given it was returning undefined when swapping between languages when just referring the the environment variable directly. This PR also adds an otel dependency that was causing the terminal to be flooded, at least locally.

What to test for/How to test

  1. Pull in branch
  2. Ensure ENVIRONMENT is set to development in your local env
  3. Type npm run dev
  4. Navigate to the dashboard
  5. Ensure that the links contain srv241 on both EN and FR
github-actions[bot] commented 2 months ago

Integration Deployment :rocket: - Build Status Default Tests Workflow Status Jest Coverage Report Cypress Coverage Report