DTU-SE-Group-D / LiRA-Viz

The new version of the project
http://se2-d.compute.dtu.dk:3000/
Apache License 2.0
2 stars 0 forks source link

small bug info card + burger button #174

Open marcosantiagomuro opened 9 months ago

marcosantiagomuro commented 9 months ago
image

so if we are in the info card "state" and we press the burger button the info card still overlays on top of it

Seb-sti1 commented 9 months ago

can you try to reproduce in v4-alpha (if you want there is this http://se2-d.compute.dtu.dk:3000/map)?

Sol2526 commented 9 months ago

This should already be fixed from my last merge.

marcosantiagomuro commented 9 months ago

it wasn't solved with the merge, what did you try sol? but too late now. it's just a small issue

Screenshot 2023-12-20 at 19 43 59
Sol2526 commented 9 months ago

Oh I see what you're saying now. Apologies. I had a similar issue. When I made my sidebar I had an issue where if I open the sidebar first, then select a road, it will give that outcome in the screenshot. Originally my cheap fix was to just move the info card more to the right so it doesn't block the surveys, and I left it like that after merge (though it looks like someone moved it back to the left). I wanted the close behavior to act like the info card. So I edited the sidebar to close automatically if a user clicks anywhere else on the screen (including clicking the top bar).

With the info card, it closes if clicked anywhere else, but it ignores the clicks on the topbar.