search

DTUAqua / spict

Stochastic surplus Production model in Continuous Time
26 stars 18 forks source link

plot(fit) #75

Open mebrooks opened 5 years ago

mebrooks commented 5 years ago

I just have a couple of suggestions for the function plot(fit)

Bottom-center panel: neither label tells me what biological pattern this is. Is it the seasonal production curve? As a novice user, I'm trying to check if the timing is right (Jan-Jan) based on my biological knowledge of the stock.

Center top and middle panel: both contain Ft/Fmsy. This seems like a waste of space/ink

alko989 commented 5 years ago

Very good suggestions @mebrooks

I think we should label the spline of the seasonal F better. I am not sure about the x-axis tick labels. One way to go is to recommend people to use calendar year for data input and adjust TAC year using decimal year for manstart, e.g. manstart = 2020.5 for a TAC year that starts in the middle of the calendar year.

And I am considering removing the absolute F and B panels and only have them plotted if the user is using the corresponding plotspict.f and plotspict.biomass.

mebrooks commented 5 years ago

One other suggestion I forgot to write down... in plotspict.seaprod(fit) the title "Sinus model" doesn't make sense in English (if that's what you're going for). It could be changed to "Sinusoidal model".

Edit: It looks like this function might not be in the master branch/fork, so my suggestion might be irrelevant here.