Computation of diff_t in the NIPALS Algorithm.

DTUComputeStatisticsAndDataAnalysis / MBPLS

(Multiblock) Partial Least Squares Regression for Python

https://mbpls.readthedocs.io

BSD 3-Clause "New" or "Revised" License

29 stars 7 forks source link

Computation of diff_t in the NIPALS Algorithm. #9

Closed sten2lu closed 4 years ago

sten2lu commented 4 years ago

In the line 855 of the MultiBlockPLS implementation in mbpls.py .

You use: diff_t = np.sum(superscores_old - superscores)

While actually the Euclidean Metric should be used as far as I understand. with: diff_t = np.sum((superscores_old - superscores)2) or diff_t = np.sum((superscores_old - superscores)2)**0.5

Could you clarify your use of this "metric" for the vectors please, in case I am mistaken?

b0nsaii commented 4 years ago

You are right @sten2lu ! Thank you for spotting this bug. We will have it fixed asap.