DTUWindEnergy / BasicDTUController

This repository is no longer being updated, and has been moved to DTU Wind Energy's GitLab server: https://gitlab.windenergy.dtu.dk/OpenLAC/BasicDTUController
GNU General Public License v3.0
23 stars 23 forks source link

Input to Generator Torque PID : Filter or not ? #26

Open amurDTU opened 6 years ago

amurDTU commented 6 years ago

According to the diagram in the manual (page 6) the rotor speed error should be filtered to calculate the generator torque reference. However, the source code indicates that the unfiltered rotor speed is used, see here : src/dtu_we_controller/turbine_controller.f90#L564 .

@profhansen Is that intentional or a mistake?

Thanks

davidovitch commented 6 years ago

ok, it seems this was changed in commit 8c978bc87b7e2b0b34b64198bce7cad89c9121d1